Subject: CVS commit: pkgsrc/pkgtools/pkglint
From: Roland Illig
Date: 2018-12-02 02:57:48
Message id: 20181202015749.971FDFB1F@cvs.NetBSD.org

Log Message:
pkgtools/pkglint: update to 5.6.7

Changes since 5.6.6:

User-defined variables that are not yet added to BUILD_DEFS are only
reported once per file.

Unnecessary space after variable names is only worth a note instead of
a warning. Example:

        MASTER_SITES =  https://cdn.example.org/

All variable names that are defined in the pkgsrc infrastructure are
assumed to be available to the package Makefiles. This reduces the
number of wrong "used but not defined" warnings, at the expense of

Variable names that are used in other variable names are checked
whether they are defined somewhere. Example:

        CFLAGS+=        ${CFLAGS.${PARAM}}      # PARAM is now checked

In SUBST_SED, when the pattern is s,@VAR@,${VAR}, or a slight variant
thereof, pkglint suggests to define SUBST_VARS instead, which frees the
package author from thinking about how to escape special characters and
is generally easier to read. Example:

        SUBST_SED.class=        s,@VAR@,${VAR:Q},

        SUBST_VARS.class=       VAR

Directives like .if !defined(...) are now handled the same whether or
not there is a space after before the (...).

The check for locally modified files now works independently of the
timezone.

As always, lots of refactorings have happened under the hood. Many small
bugs have been discovered and fixed accordingly.

Files:
RevisionActionfile
1.559modifypkgsrc/pkgtools/pkglint/Makefile
1.7modifypkgsrc/pkgtools/pkglint/files/alternatives.go
1.8modifypkgsrc/pkgtools/pkglint/files/alternatives_test.go
1.13modifypkgsrc/pkgtools/pkglint/files/autofix.go
1.13modifypkgsrc/pkgtools/pkglint/files/autofix_test.go
1.15modifypkgsrc/pkgtools/pkglint/files/buildlink3.go
1.21modifypkgsrc/pkgtools/pkglint/files/buildlink3_test.go
1.29modifypkgsrc/pkgtools/pkglint/files/check_test.go
1.24modifypkgsrc/pkgtools/pkglint/files/distinfo.go
1.20modifypkgsrc/pkgtools/pkglint/files/distinfo_test.go
1.22modifypkgsrc/pkgtools/pkglint/files/files.go
1.20modifypkgsrc/pkgtools/pkglint/files/files_test.go
1.17modifypkgsrc/pkgtools/pkglint/files/licenses.go
1.18modifypkgsrc/pkgtools/pkglint/files/licenses_test.go
1.28modifypkgsrc/pkgtools/pkglint/files/line.go
1.15modifypkgsrc/pkgtools/pkglint/files/line_test.go
1.10modifypkgsrc/pkgtools/pkglint/files/linechecker.go
1.10modifypkgsrc/pkgtools/pkglint/files/linechecker_test.go
1.2modifypkgsrc/pkgtools/pkglint/files/lines.go
1.17modifypkgsrc/pkgtools/pkglint/files/logging.go
1.7modifypkgsrc/pkgtools/pkglint/files/logging_test.go
1.41modifypkgsrc/pkgtools/pkglint/files/mkline.go
1.45modifypkgsrc/pkgtools/pkglint/files/mkline_test.go
1.23modifypkgsrc/pkgtools/pkglint/files/mklinechecker.go
1.19modifypkgsrc/pkgtools/pkglint/files/mklinechecker_test.go
1.35modifypkgsrc/pkgtools/pkglint/files/mklines.go
1.31modifypkgsrc/pkgtools/pkglint/files/mklines_test.go
1.20modifypkgsrc/pkgtools/pkglint/files/mkparser.go
1.18modifypkgsrc/pkgtools/pkglint/files/mkparser_test.go
1.9modifypkgsrc/pkgtools/pkglint/files/mkshparser.go
1.8modifypkgsrc/pkgtools/pkglint/files/mkshparser_test.go
1.10modifypkgsrc/pkgtools/pkglint/files/mkshtypes.go
1.5modifypkgsrc/pkgtools/pkglint/files/mkshwalker_test.go
1.7modifypkgsrc/pkgtools/pkglint/files/mktypes.go
1.8modifypkgsrc/pkgtools/pkglint/files/options.go
1.39modifypkgsrc/pkgtools/pkglint/files/package.go
1.33modifypkgsrc/pkgtools/pkglint/files/package_test.go
1.12modifypkgsrc/pkgtools/pkglint/files/parser.go
1.10modifypkgsrc/pkgtools/pkglint/files/parser_test.go
1.25modifypkgsrc/pkgtools/pkglint/files/patches.go
1.24modifypkgsrc/pkgtools/pkglint/files/patches_test.go
1.41modifypkgsrc/pkgtools/pkglint/files/pkglint.go
1.28modifypkgsrc/pkgtools/pkglint/files/pkglint_test.go
1.13modifypkgsrc/pkgtools/pkglint/files/pkgsrc.go
1.11modifypkgsrc/pkgtools/pkglint/files/pkgsrc_test.go
1.32modifypkgsrc/pkgtools/pkglint/files/plist.go
1.28modifypkgsrc/pkgtools/pkglint/files/plist_test.go
1.29modifypkgsrc/pkgtools/pkglint/files/shell.go
1.3modifypkgsrc/pkgtools/pkglint/files/shell.y
1.34modifypkgsrc/pkgtools/pkglint/files/shell_test.go
1.13modifypkgsrc/pkgtools/pkglint/files/shtokenizer.go
1.11modifypkgsrc/pkgtools/pkglint/files/shtokenizer_test.go
1.11modifypkgsrc/pkgtools/pkglint/files/shtypes.go
1.6modifypkgsrc/pkgtools/pkglint/files/shtypes_test.go
1.16modifypkgsrc/pkgtools/pkglint/files/substcontext.go
1.17modifypkgsrc/pkgtools/pkglint/files/substcontext_test.go
1.8modifypkgsrc/pkgtools/pkglint/files/tools.go
1.8modifypkgsrc/pkgtools/pkglint/files/tools_test.go
1.15modifypkgsrc/pkgtools/pkglint/files/toplevel.go
1.32modifypkgsrc/pkgtools/pkglint/files/util.go
1.18modifypkgsrc/pkgtools/pkglint/files/util_test.go
1.50modifypkgsrc/pkgtools/pkglint/files/vardefs.go
1.7modifypkgsrc/pkgtools/pkglint/files/vardefs_test.go
1.21modifypkgsrc/pkgtools/pkglint/files/vartype.go
1.11modifypkgsrc/pkgtools/pkglint/files/vartype_test.go
1.44modifypkgsrc/pkgtools/pkglint/files/vartypecheck.go
1.36modifypkgsrc/pkgtools/pkglint/files/vartypecheck_test.go
1.7modifypkgsrc/pkgtools/pkglint/files/getopt/getopt.go
1.9modifypkgsrc/pkgtools/pkglint/files/getopt/getopt_test.go
1.2modifypkgsrc/pkgtools/pkglint/files/intqa/testnames.go
1.6modifypkgsrc/pkgtools/pkglint/files/licenses/licenses.go
1.2modifypkgsrc/pkgtools/pkglint/files/textproc/lexer.go
1.2modifypkgsrc/pkgtools/pkglint/files/textproc/lexer_test.go
1.4modifypkgsrc/pkgtools/pkglint/files/trace/tracing.go
1.1addpkgsrc/pkgtools/pkglint/files/lines_test.go
1.1addpkgsrc/pkgtools/pkglint/files/intqa/ideas.go
1.1addpkgsrc/pkgtools/pkglint/files/textproc/lexer_bench_test.go