Subject: CVS commit: pkgsrc/geography/py-country
From: Adam Ciarcinski
Date: 2019-05-31 14:37:04
Message id: 20190531123705.13133FB15@cvs.NetBSD.org

Log Message:
py-country: updated to 18.12.8

18.12.8:
WARNING: This release contains a subtle but important API change that may break \ 
integrations!
Looking at 13416 I realized that I made a terrible API design choice with \ 
respect to how the get function should behave in Python. Probably under the \ 
influence of either too little or too much whiskey I went and implemented get so \ 
that it raises a KeyError instead of doing the Pythonic thing and returning None \ 
and allowing to customize the default. There was a bit of back-and-forth around \ 
this code in previous releases (specifically touching edge cases to have the \ 
Subdivision API behave “reasonably”, although there doesn’t seem to be one \ 
right way there.)
Anyway, when preparing this release and reviewing 13416 and the other related \ 
issues and changes from the past I noticed my mistake an decide to fix it going \ 
forward.
So, from now on get will behave as expected in Python and yes, this means you \ 
will have to update your integration code carefully now checking for None \ 
returns instead of expecting KeyErrors. This is work, but I think it’s \ 
worthwhile to uphold this convention within the Python community.

* Switch API from “get + KeyError” to ” get + default=None”. This is a \ 
subtle API-breaking change. Please update carefully.
* Update to iso-codes 4.1.

Files:
RevisionActionfile
1.5modifypkgsrc/geography/py-country/distinfo
1.4modifypkgsrc/geography/py-country/PLIST
1.5modifypkgsrc/geography/py-country/Makefile