Subject: CVS commit: pkgsrc/x11/Xaw3d
From: Mark Davies
Date: 2006-03-13 01:16:23
Message id: 20060313001623.74F062DA27@cvs.netbsd.org

Log Message:
The x11/Xaw3d library has an integer overflow error in the computation
of the geometry for a Box Layout (file Box.c).  There, the box tries
to extend its width until its height fits within the constraint height
(influenced by the window manager).  Unfortunately, widths are 16bit
unsigned and in the error case (occuring under KDE), the constraint
width is 65535, i.e. maximal.
The code loops until either the computed height is smaller than the
constraint height or the width exceeds the constraint width.  In each
loop iteration, the width of the box layout is doubled.  This loop
does not terminate, if one chooses unfortunate initial width, as the
width wraps around if it overflows 16 bits and if the maximal
constraint width is SHORT_INT_MAX.
Patch tries to capture the overflow before it wraps around the
`width' variable, setting the width to the maximal one.

>From Stephan Thesing in PR pkg/32445. Bump PKGREVISION.

Files:
RevisionActionfile
1.48modifypkgsrc/x11/Xaw3d/Makefile
1.9modifypkgsrc/x11/Xaw3d/distinfo
1.1addpkgsrc/x11/Xaw3d/patches/patch-ac