Subject: CVS commit: pkgsrc/pkgtools/pkg_rolling-replace
From: Greg Troxel
Date: 2010-12-20 16:24:25
Message id: 20101220152425.3FA0F175DD@cvs.netbsd.org

Log Message:
0.22: Avoid infinite loop in some error cases.

Sometimes, the set of packages to be replaced ($REPLACE_TODO) does not
have any members which are installed (and hence in $TSORTED).  This
caused the loop over $TSORTED to not find any packages to replace.
The check for not having found one was missing, resulting in the last
package in TSORTED being replaced.  Because $REPLACE_TODO is still
non-empty, this repeats.

This patch adds an abort when no packages in $TSORTED are in
$REPLACE_TODO.  Analysis and patch from Ian D. Leroux on
pkgsrc-users@.

Files:
RevisionActionfile
1.30modifypkgsrc/pkgtools/pkg_rolling-replace/Makefile
1.29modifypkgsrc/pkgtools/pkg_rolling-replace/files/pkg_rolling-replace.sh