Subject: CVS commit: pkgsrc
From: Taylor R Campbell
Date: 2025-01-24 13:45:54
Message id: 20250124124554.91B0BFBE0@cvs.NetBSD.org

Log Message:
editors/neovim: Use buildlink3, not DEPENDS, for lua-lpeg.

Will be needed when we hide PREFIX from cmake.  Will resolve:

CMake Error at \ 
/pkg/2024Q4/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 \ 
(message):
  Could NOT find Lpeg (missing: LPEG_LIBRARY)
Call Stack (most recent call first):
  /pkg/2024Q4/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 \ 
(_FPHSA_FAILURE_MESSAGE)
  cmake/FindLpeg.cmake:3 (find_package_handle_standard_args)
  src/nvim/CMakeLists.txt:34 (find_package)

-- Configuring incomplete, errors occurred!
*** Error code 1

While here, use COMPILER_RPATH_FLAG instead of editing the rpath in ex
post facto -- resolves:

-- Install configuration: "Release"
/home/riastradh/pkgsrc/current/pkg/bin/patchelf \ 
/home/riastradh/pkgsrc/current/work/editors/neovim/work/.destdir/home/riastradh/pkgsrc/current/pkg/bin/nvim \ 
 --replace-needed /home/riastradh/pkgsrc/current/pkg/lib/lua/5.1/lpeg.so lpeg.so
/home/riastradh/pkgsrc/current/pkg/bin/patchelf \ 
/home/riastradh/pkgsrc/current/work/editors/neovim/work/.destdir/home/riastradh/pkgsrc/current/pkg/bin/nvim \ 
 --add-rpath /home/riastradh/pkgsrc/current/pkg/lib/lua/5.1
patchelf: getting info about '--add-rpath': No such file or directory

Verified that the NEEDED and RPATH entries look reasonable:

$ readelf -d \ 
~/pkgsrc/current/work/editors/neovim/work/.destdir/home/riastradh/pkgsrc/current/pkg/bin/nvim \ 
| grep -e lpeg.so -e RPATH
 0x0000000000000001 (NEEDED)             Shared library: [lpeg.so]
 0x000000000000000f (RPATH)              Library rpath: \ 
[/home/riastradh/pkgsrc/current/pkg/gcc10/x86_64--netbsd/lib/.:/home/riastradh/p \ 
kgsrc/current/pkg/lib/lua/5.1:/home/riastradh/pkgsrc/current/pkg/gcc10/lib/gcc/x \ 
86_64--netbsd/10.5.0:/home/riastradh/pkgsrc/current/pkg/lib:/home/riastradh/pkgs \ 
rc/current/pkg/lib/libvterm03

XXX Would be nice to hard-code the Lua version a little less here.

Files:
RevisionActionfile
1.12modifypkgsrc/editors/neovim/Makefile
1.1addpkgsrc/devel/lua-lpeg/buildlink3.mk